Review add-ansible-role doc #185

Merged

eblume merged 1 commit from review/add-ansible-role into main

2026-02-13 16:54:42 -08:00

eblume commented

2026-02-13 16:54:25 -08:00

Owner

Summary

Replace op item get --fields with op read for secrets (matches playbook and CLAUDE.md guidance)
Change tags: [<role>] to tags: <role> to match actual playbook style
Remove redundant listen: from handler example, add changed_when: true
Name handler after specific service (e.g. Restart <service>) to match real roles
Add last-reviewed: 2026-02-13 frontmatter

Also noted (not fixed here)

Two other docs still use the old op item get pattern:

docs/how-to/troubleshooting.md:72 (ArgoCD login command)
docs/how-to/gandi-operations.md:35 (Gandi token export)

These can be fixed in their own review cycles.

## Summary - Replace `op item get --fields` with `op read` for secrets (matches playbook and CLAUDE.md guidance) - Change `tags: [<role>]` to `tags: <role>` to match actual playbook style - Remove redundant `listen:` from handler example, add `changed_when: true` - Name handler after specific service (e.g. `Restart <service>`) to match real roles - Add `last-reviewed: 2026-02-13` frontmatter ## Also noted (not fixed here) Two other docs still use the old `op item get` pattern: - `docs/how-to/troubleshooting.md:72` (ArgoCD login command) - `docs/how-to/gandi-operations.md:35` (Gandi token export) These can be fixed in their own review cycles.

eblume added 1 commit

2026-02-13 16:54:26 -08:00

Review add-ansible-role doc: fix patterns to match reality bf9cbfca24

- Replace `op item get --fields` with `op read` for secrets
- Change `tags: [<role>]` to `tags: <role>` to match playbook style
- Remove redundant `listen:` from handler, add `changed_when: true`
- Name handler after specific service to match real role convention
- Add last-reviewed frontmatter

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>