From c57181aa6089f865a078bf67a0756277a56ad40d Mon Sep 17 00:00:00 2001
From: Mick Grove <mick.grove@mongodb.com>
Date: Thu, 15 Jan 2026 10:41:55 -0800
Subject: [PATCH] improving findings viewer

---
 CHANGELOG.md                      |  2 ++
 data/rules/azurestorage.yml       |  5 +++--
 docs/access-map-viewer/index.html | 23 +++++++++++++++++++++++
 3 files changed, 28 insertions(+), 2 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 49abda4..bb5cbaa 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -5,6 +5,8 @@ All notable changes to this project will be documented in this file.
 ## [v1.75.0]
 - Enhanced Access Map View: added fingerprint display, enabled searching by fingerprint, and implemented bidirectional navigation between Findings and Access Map nodes.
 - Added Slack Access Map support with granular permissions in the tree view.
+- Improved HTML report
+- Improved several rules
 
 ## [v1.74.0]
 - Added new rules: cursor, definednetworking, filezilla, harness, intra42, klingai, lark, mergify, naver, plaid, resend, retellai
diff --git a/data/rules/azurestorage.yml b/data/rules/azurestorage.yml
index edebb26..910de23 100644
--- a/data/rules/azurestorage.yml
+++ b/data/rules/azurestorage.yml
@@ -6,16 +6,17 @@ rules:
       (?:
         # A) Connection string: AccountName=<name>
         (?i:AccountName)\s*=\s*([a-z0-9]{3,24})(?:\b|[^a-z0-9])
-
       |
         # B) Blob endpoint URL: <name>.blob.core.windows.net
         ([a-z0-9]{3,24})\.blob\.core\.windows\.net\b
-
       |
         # C) Explicit KV labels near 'azure storage/account name' with tight separators
         \bazure(?:[_\s-]*)(?:storage|account)(?:[_\s-]*)(?:name)\b
         [\s:=\"']{0,6}
         ([a-z0-9]{3,24})(?:\b|[^a-z0-9])
+      |
+        # D) Explicit KV labels near 'azure storage/account name' with tight separators
+        (?i:Account[_.-]?Name|Storage[_.-]?(?:Name))(?:.|\s){0,32}?\b([A-Z0-9]{3,32})\b|([A-A0-9]{3,32})(?i:\.blob\.core\.windows\.net)
       )
     min_entropy: 2.0
     visible: false
diff --git a/docs/access-map-viewer/index.html b/docs/access-map-viewer/index.html
index c4dd8af..5831fdd 100644
--- a/docs/access-map-viewer/index.html
+++ b/docs/access-map-viewer/index.html
@@ -1123,6 +1123,10 @@
                     <label>Git Commit</label>
                     <div id="fd-commit"></div>
                   </div>
+                  <div class="detail-field" id="fd-committer-email-wrapper">
+                    <label>Committer Email</label>
+                    <div id="fd-committer-email"></div>
+                  </div>
                   <div class="detail-field">
                     <label>File Path</label>
                     <textarea id="fd-path" class="path-area" readonly></textarea>
@@ -2372,6 +2376,25 @@
           : "N/A";
       document.getElementById("fd-commit").textContent = commit;
 
+      const committerWrapper = document.getElementById("fd-committer-email-wrapper");
+      const committerEmailEl = document.getElementById("fd-committer-email");
+      const committerEmail =
+        finding.git_metadata &&
+        finding.git_metadata.commit &&
+        finding.git_metadata.commit.committer &&
+        finding.git_metadata.commit.committer.email
+          ? String(finding.git_metadata.commit.committer.email)
+          : "";
+      if (committerWrapper && committerEmailEl) {
+        if (committerEmail) {
+          committerWrapper.style.display = "";
+          committerEmailEl.textContent = committerEmail;
+        } else {
+          committerWrapper.style.display = "none";
+          committerEmailEl.textContent = "";
+        }
+      }
+
       const statusRaw =
         finding.validation && finding.validation.status ? String(finding.validation.status) : "Unknown";
       const normalizedStatus = normalizeValidationStatus(statusRaw);