Updated kingfisher scan to accept Git repository URLs as positional targets (for example kingfisher scan github.com/org/repo or kingfisher scan https://gitlab.com/group/project.git) without requiring --git-url.

tests/cli_git_clone_flags.rs

@@ -12,7 +12,6 @@ fn parse_git_clone_dir_and_keep_clones() -> anyhow::Result<()> {
     let args = CommandLineArgs::try_parse_from([
         "kingfisher",
         "scan",
-        "--git-url",
         "https://github.com/octocat/Hello-World.git",
         "--git-clone-dir",
         dir.path().to_str().unwrap(),
@@ -41,8 +40,7 @@ fn keep_clones_defaults_to_false() -> anyhow::Result<()> {
     let args = CommandLineArgs::try_parse_from([
         "kingfisher",
         "scan",
-        "--git-url",
-        "https://github.com/octocat/Hello-World.git",
+        "github.com/octocat/Hello-World",
         "--no-update-check",
     ])?;
 
@@ -62,6 +60,70 @@ fn keep_clones_defaults_to_false() -> anyhow::Result<()> {
     Ok(())
 }
 
+#[test]
+fn deprecated_git_url_flag_still_parses() -> anyhow::Result<()> {
+    let args = CommandLineArgs::try_parse_from([
+        "kingfisher",
+        "scan",
+        "--git-url",
+        "https://github.com/octocat/Hello-World.git",
+        "--no-update-check",
+    ])?;
+
+    let command = match args.command {
+        Command::Scan(scan_args) => scan_args,
+        other => panic!("unexpected command parsed: {:?}", other),
+    };
+
+    let scan_args = match command.into_operation()? {
+        ScanOperation::Scan(scan_args) => scan_args,
+        op => panic!("expected scan operation, got {:?}", op),
+    };
+
+    assert_eq!(scan_args.input_specifier_args.git_url.len(), 1);
+    assert_eq!(
+        scan_args.input_specifier_args.git_url[0].as_str(),
+        "https://github.com/octocat/Hello-World.git"
+    );
+    assert!(scan_args.input_specifier_args.path_inputs.is_empty());
+
+    Ok(())
+}
+
+#[test]
+fn positional_git_url_examples_parse() -> anyhow::Result<()> {
+    let examples = [
+        ("github.com/kubernetes/kubernetes", "https://github.com/kubernetes/kubernetes"),
+        ("https://github.com/org/repo", "https://github.com/org/repo"),
+        ("gitlab.com/gitlab-org/gitlab", "https://gitlab.com/gitlab-org/gitlab"),
+        (
+            "https://gitlab.com/namespace/project.git",
+            "https://gitlab.com/namespace/project.git",
+        ),
+    ];
+
+    for (input, expected) in examples {
+        let args =
+            CommandLineArgs::try_parse_from(["kingfisher", "scan", input, "--no-update-check"])?;
+
+        let command = match args.command {
+            Command::Scan(scan_args) => scan_args,
+            other => panic!("unexpected command parsed: {:?}", other),
+        };
+
+        let scan_args = match command.into_operation()? {
+            ScanOperation::Scan(scan_args) => scan_args,
+            op => panic!("expected scan operation, got {:?}", op),
+        };
+
+        assert_eq!(scan_args.input_specifier_args.git_url.len(), 1);
+        assert_eq!(scan_args.input_specifier_args.git_url[0].as_str(), expected);
+        assert!(scan_args.input_specifier_args.path_inputs.is_empty());
+    }
+
+    Ok(())
+}
+
 #[test]
 fn turbo_mode_applies_speed_first_defaults() -> anyhow::Result<()> {
     let args = CommandLineArgs::try_parse_from([