From 1603b37f74274a850339cb65ef37096736bee3ba Mon Sep 17 00:00:00 2001
From: Erich Blume <blume.erich@gmail.com>
Date: Thu, 4 Jun 2026 10:20:23 -0700
Subject: [PATCH] fix: --version no longer false-positives -dirty on clean
 release installs
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The build-time dirty check used `git status --porcelain`, which counts
untracked files — including cargo's own `.cargo-ok` marker in a
`cargo install --git` checkout — so a clean tagged build reported e.g.
`1.0.1 (bcab3c16b-dirty)`. Use `git diff --quiet HEAD` (tracked changes only).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
---
 crates/heph-core/build.rs                          | 14 +++++++++-----
 docs/changelog.d/+version-no-false-dirty.bugfix.md |  1 +
 2 files changed, 10 insertions(+), 5 deletions(-)
 create mode 100644 docs/changelog.d/+version-no-false-dirty.bugfix.md

diff --git a/crates/heph-core/build.rs b/crates/heph-core/build.rs
index f0fe636..7f52741 100644
--- a/crates/heph-core/build.rs
+++ b/crates/heph-core/build.rs
@@ -35,10 +35,14 @@ fn git_short_sha() -> Option<String> {
     if sha.is_empty() {
         return None;
     }
-    let dirty = Command::new("git")
-        .args(["status", "--porcelain"])
-        .output()
-        .map(|o| !o.stdout.is_empty())
-        .unwrap_or(false);
+    // Tracked changes only. `git status --porcelain` would also count
+    // untracked files — including cargo's own `.cargo-ok` marker in a
+    // `cargo install --git` checkout — and falsely tag a clean release build
+    // `-dirty`. `git diff --quiet HEAD` exits non-zero only on tracked edits.
+    let dirty = !Command::new("git")
+        .args(["diff", "--quiet", "HEAD"])
+        .status()
+        .map(|s| s.success())
+        .unwrap_or(true);
     Some(if dirty { format!("{sha}-dirty") } else { sha })
 }
diff --git a/docs/changelog.d/+version-no-false-dirty.bugfix.md b/docs/changelog.d/+version-no-false-dirty.bugfix.md
new file mode 100644
index 0000000..2b0bd04
--- /dev/null
+++ b/docs/changelog.d/+version-no-false-dirty.bugfix.md
@@ -0,0 +1 @@
+Fix `heph`/`hephd` `--version` falsely showing a `-dirty` suffix on clean release installs. The build-time dirty check now considers only tracked modifications (`git diff --quiet HEAD`) instead of counting untracked files such as cargo's own `.cargo-ok` marker in a `cargo install --git` checkout.