From b000efd6c333d192563ce0772d72e6bae6171ece Mon Sep 17 00:00:00 2001
From: Erich Blume <blume.erich@gmail.com>
Date: Mon, 30 Mar 2026 07:16:02 -0700
Subject: [PATCH] Fix Kingfisher CronJob exit code handling

Kingfisher exits 200 (findings) or 205 (validated findings) on success.
Normalize these to 0 so the CronJob completes instead of restarting.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
---
 argocd/manifests/kingfisher/cronjob.yaml | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/argocd/manifests/kingfisher/cronjob.yaml b/argocd/manifests/kingfisher/cronjob.yaml
index 9874eae..d05fc0c 100644
--- a/argocd/manifests/kingfisher/cronjob.yaml
+++ b/argocd/manifests/kingfisher/cronjob.yaml
@@ -26,6 +26,9 @@ spec:
                   OUTDIR=/reports/kingfisher
                   mkdir -p "$OUTDIR"
 
+                  # Exit codes: 0=clean, 200=findings, 205=validated findings.
+                  # All are successful scans; only other codes are real errors.
+                  rc=0
                   kingfisher scan gitea \
                     --api-url https://forge.ops.eblu.me/api/v1/ \
                     --clone-url-base https://forge.ops.eblu.me/ \
@@ -35,7 +38,13 @@ spec:
                     --tls-mode lax \
                     --allow-internal-ips \
                     --format html \
-                    --output "$OUTDIR/scan-${STAMP}.html"
+                    --output "$OUTDIR/scan-${STAMP}.html" \
+                  || rc=$?
+
+                  if [ "$rc" -eq 0 ] || [ "$rc" -eq 200 ] || [ "$rc" -eq 205 ]; then
+                    exit 0
+                  fi
+                  exit "$rc"
               env:
                 - name: KF_GITEA_TOKEN
                   valueFrom: